1u0 commented on issue #7795: [FLINK-11716] Add new config option for TaskManager automatic address binding URL: https://github.com/apache/flink/pull/7795#issuecomment-466343355 > As noted in my earlier comment in the prior PR, I would get rid of the `AUTO_DETECT` option and let `ip` and `hostname` use the auto detect logic (with `hostname` as default as currently). I've given some reason in [the comment in the old PR](7745#discussion_r258397017). Also from the feedback, I got that **it is ok if** the default stays the same for now. Additional motivation to split those things explicitly are: * providing separate simple `hostname`, `ip` mechanisms early, may allow the Flink community to try them out and give feedback if simple bindings don't work for some people and the heuristic based one is needed in such cases (this would require some pro-activity on users' side, but in that case they may also share what is their setup). * `ip` option is a new one. So far, nobody has asked explicitly for it and especially for a version with heuristic address detection. There is a hope that it would mitigate [[FLINK-11127]](https://issues.apache.org/jira/browse/FLINK-11127) until a proper fix. But for Kubernetes case, the heuristic address detection has weak value and guarantees (when JM and TMs started in parallel without external coordination). In the worst case (for FLINK-11127), this option is not helpful at all and users have to fallback to old workarounds. On a good side, if it helps, then it's one more argument that heuristic auto detection is not needed (in Kubernetes setups). > There was also another question about using `InetAddress.getByName(address)` instead of `getHostAdress`. Maybe there is some misunderstanding. The `address` in your snippet is not some random input, but `InetAddress.getLocalHost().getHostName()`. I don't see much value in (effectively, what you propose) ``` InetAddress address = InetAddress.getLocalHost(); address = InetAddress.getByName(address.getHostName()); return address.getHostAddress(); ``` compared to ``` InetAddress address = InetAddress.getLocalHost(); return address.getHostAddress(); ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
