zhijiangW opened a new pull request #7807: [FLINK-11723][network] Remove KvState related components from Network… URL: https://github.com/apache/flink/pull/7807 ## What is the purpose of the change *The `NetworkEnvironment` would be refactored into `NetworkShuffleService` created by `ShuffleManager` future. So the `NetworkEnvironment` should only cover shuffle related components to make the preparation.* *Currently `KvStateRegistry`, `KvStateServer`, `KvStateClientProxy` are not related to shuffle process and mainly used to be got in `TaskExecutor`. So it is reasonable to remove them from `NetworkEnvironment`.* *And then we could introduce a new `KvStateService` for wrapping these three components and pass it into `TaskManagerService`. This new service can also be passed into `TaskExecutor`, `Task` for use and avoid spreading in messy.* ## Brief change log - *Remove `KvStateRegistry`, `KvStateServer`, `KvStateClientProxy` from `NetworkEnvironment`* - *Introduce `KvStateService` as a component of task manager services* - *Pass `KvStateService` into `TaskExecutor` and `Task`* ## Verifying this change This change is already covered by existing tests, such as *NetworkEnvironmentTest*. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (yes / **no**) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**) - The serializers: (yes / **no** / don't know) - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know) - The S3 file system connector: (yes / **no** / don't know) ## Documentation - Does this pull request introduce a new feature? (yes / **no**) - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
