dawidwys commented on a change in pull request #7747: [FLINK-11653][DataStream]
Add configuration to enforce custom UID's o…
URL: https://github.com/apache/flink/pull/7747#discussion_r259306760
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGenerator.java
##########
@@ -348,6 +348,13 @@ private StreamConfig createJobVertex(
"Did you generate them before calling
this method?");
}
+ if
(!streamGraph.getExecutionConfig().hasAutoGeneratedUIDsEnabled()) {
Review comment:
I don't think this is the best place to check it.
Why don't we move the check to
`org.apache.flink.streaming.api.graph.StreamGraphGenerator#transform`? I think
what we want to effectively enforce is that a `StreamTransformation` has either
`uid` or `userHash` set, don't we?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
