TisonKun commented on a change in pull request #7809: [FLINK-11710][tests]
Refactor SimpleSlotProvider to TestingLogicalSlo…
URL: https://github.com/apache/flink/pull/7809#discussion_r259317625
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/AllocatedSlot.java
##########
@@ -41,7 +41,7 @@
* an AllocatedSlot was allocated to the JobManager as soon as the TaskManager
registered at the
* JobManager. All slots had a default unknown resource profile.
*/
-class AllocatedSlot implements PhysicalSlot {
+public class AllocatedSlot implements PhysicalSlot {
Review comment:
@tillrohrmann I need a subclass of `SlotContext` in this pr. IIRC we've had
a conversation where you said that `AllocatedSlot` is package private since it
should be used in only `SlotPool`.
Now that `AllocatedSlot` has a public constructor, I'd like to know whether
we make this change(add `public`) or introduce a `SettableSlotContext` and mark
`AllocatedSlot`'s constructor to package-private.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
