[
https://issues.apache.org/jira/browse/FLINK-2586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14717198#comment-14717198
]
Matthias J. Sax commented on FLINK-2586:
----------------------------------------
You are right. It's not the kill thing. However the problem is basically the
same. (1) `submitToplogy()` is an non-blocking call; (2) in Storm, topologies
run forever. Thus, there is no way to determine when `killTopology` should be
called (without very mean hacks). We could only add a Flink specific blocking
flag, that make the call to `submitTopology()` blocking. Furthermore, we need
to ensure, that the Spouts terminate by themselves (via implement
`FiniteSpoutInterface`). So far, the test passed all the time, so I though it
should be fine as is. Obviously, I was wrong (and I have to confess, that I
don't like the current implementation either -- I only did it this way to be as
close to Storm semantics as possible).
> Unstable Storm Compatibility Tests
> ----------------------------------
>
> Key: FLINK-2586
> URL: https://issues.apache.org/jira/browse/FLINK-2586
> Project: Flink
> Issue Type: Bug
> Components: Storm Compatibility
> Affects Versions: 0.10
> Reporter: Stephan Ewen
> Priority: Critical
> Fix For: 0.10
>
>
> The Storm Compatibility tests frequently fail.
> The reason is that they kill the topologies after a certain time interval.
> That may fail on CI infrastructure when certain steps are delayed beyond
> usual. Trying to guarantee progress by time is inherently problematic:
> - Waiting too short makes tests unstable
> - Waiting too long makes tests slow
> The right way to go is letting the program decide when to terminate, for
> example by throwing a special {{SuccessException}}.
> Have a look at the Kafka connector tests, they do this a lot and hence run
> exactly as short or as long as they need to.
> Here is an example of a failed run:
> https://s3.amazonaws.com/archive.travis-ci.org/jobs/77499577/log.txt
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
