tzulitai commented on issue #7726: [FLINK-10342] Filter restored partitions with discovered partitions b… URL: https://github.com/apache/flink/pull/7726#issuecomment-467265871 @fengli one comment about addressing reviews: Unless necessary, I suggest to only push follow-up commits to address review comments to retain the history of the PR, and do not force-push / squash commits yet. If you always squash and force-push for every review pass, it may be hard for the reviewer to follow the changes. It might be ok for smaller PRs like this one, but once the PR gets bigger and reviewers only revisits the PR after a few days, it will get tough to recall what happened in past reviews.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
