wuchong commented on a change in pull request #7817: [FLINK-11702][table-planner-blink] Introduce a new table type system: InternalType URL: https://github.com/apache/flink/pull/7817#discussion_r260132981
########## File path: flink-table/flink-table-planner-blink/src/test/java/org/apache/flink/table/type/InternalTypeTest.java ########## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.type; + +import org.apache.flink.api.common.typeinfo.TypeInformation; +import org.apache.flink.api.common.typeinfo.Types; +import org.apache.flink.api.common.typeutils.CompositeType; +import org.apache.flink.api.java.typeutils.RowTypeInfo; +import org.apache.flink.util.InstantiationUtil; + +import org.junit.Assert; +import org.junit.Test; + +import java.io.IOException; + +/** + * Test for {@link InternalType}s. + */ +public class InternalTypeTest { + + @Test + public void testHashCodeAndEquals() throws IOException, ClassNotFoundException { + testHashCodeAndEquals(InternalTypes.INT); + testHashCodeAndEquals(new DecimalType(15, 5)); + testHashCodeAndEquals(new GenericType<>(InternalTypeTest.class)); + testHashCodeAndEquals(new RowType(InternalTypes.STRING, InternalTypes.INT, InternalTypes.INT)); + testHashCodeAndEquals(new ArrayType(InternalTypes.STRING)); + testHashCodeAndEquals(new MapType(InternalTypes.STRING, InternalTypes.INT)); + } + + private void testHashCodeAndEquals(InternalType type) throws IOException, ClassNotFoundException { + InternalType newType = InstantiationUtil.deserializeObject + (InstantiationUtil.serializeObject(type), + Thread.currentThread().getContextClassLoader()); + + Assert.assertEquals(type.hashCode(), newType.hashCode()); + Assert.assertEquals(type, newType); + } + + @Test + public void testConverter() throws IOException, ClassNotFoundException { + testConvertToRowType(new RowTypeInfo( + new TypeInformation[] {Types.INT, Types.STRING}, + new String[] {"field1", "field2"})); + testConvertToRowType((CompositeType) TypeInformation.of(MyPojo.class)); + } + + private void testConvertToRowType(CompositeType typeInfo) { + RowType rowType = (RowType) TypeConverters.createInternalTypeFromTypeInfo(typeInfo); Review comment: I think we should also test other types conversion, including basic types, array types, primitive array types, map types, etc... ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
