[ 
https://issues.apache.org/jira/browse/FLINK-2556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14717579#comment-14717579
 ] 

ASF GitHub Bot commented on FLINK-2556:
---------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/1044


> Fix/Refactor pre-flight Key validation
> --------------------------------------
>
>                 Key: FLINK-2556
>                 URL: https://issues.apache.org/jira/browse/FLINK-2556
>             Project: Flink
>          Issue Type: Bug
>          Components: Java API
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>
> The pre-flight key validation checks are inconsistent, at times don't 
> actually check anything and in at least 1 case are done redundantly.
> For example,
> * you can group on a tuple containing a non-Atomic-/CompositeType using 
> String[] KeyExpressions (see FLINK-2541)
> * you can group on an AtomicType even though isKeyType() returns false, if it 
> is contained in a tuple
> * for distinct(String[]...) the above fails in the DistinctOperator 
> constructor, as it validates the key again for some reason.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to