zhijiangW opened a new pull request #7835: [FLINK-11750][network] Refactor the creation of ResultPartitionID in IntermediateResultPartition URL: https://github.com/apache/flink/pull/7835 ## What is the purpose of the change *The motivation of task is for preparing the creation of `ResultPartition` via `ShuffleService` future. Currently during the creation of `ResultPartition` we need the `ExecutionAttemptID` info to generate `ResultPartitionID`. To make the interface of `ShuffleService#createResultPartitionWriter` clean, it is better to get `ResultPartitionID` directly from `ResultPartitionDeploymentDescriptor` instead of explicitly passing additional `ExecutionAttemptID`.* *We could create this `ResultPartitionID` in the constructor of `IntermediateResultPartition`, then it can be got directly by other classes to avoid repeatedly creation anywhere. Meanwhile this change would simply the related codes.* ## Brief change log - *Creates `ResultPartitionID` during generating `IntermediateResultPartition`* - *Modifies other related places to get `ResultPartitionID` directly instead of repeatedly creation* ## Verifying this change This change is already covered by existing tests, such as *ResultPartitionDeploymentDescriptorTest*. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (yes / **no**) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**) - The serializers: (yes / **no** / don't know) - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know) - The S3 file system connector: (yes / **no** / don't know) ## Documentation - Does this pull request introduce a new feature? (yes / **no**) - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
