[
https://issues.apache.org/jira/browse/FLINK-11750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
zhijiang updated FLINK-11750:
-----------------------------
Description:
The motivation of task is for preparing the creation of {{ResultPartition}} via
{{ShuffleService}} future.
Currently during the creation of {{ResultPartition}} we need the
{{ExecutionAttemptID}} info to generate {{ResultPartitionID}}. To make the
interface of {{ShuffleService#createResultPartitionWriter}} clean, it is better
to get {{ResultPartitionID}} directly from
{{ResultPartitionDeploymentDescriptor}} instead of explicitly passing
additional {{ExecutionAttemptID}}.
We could create this {{ResultPartitionID}} during generating
{{ResultPartitionDeploymentDescriptor}} to replace the original field of
{{IntermediateResultPartitionID}}.
was:
The motivation of task is for preparing the creation of {{ResultPartition}} via
{{ShuffleService}} future.
Currently during the creation of {{ResultPartition}} we need the
{{ExecutionAttemptID}} info to generate {{ResultPartitionID}}. To make the
interface of {{ShuffleService#createResultPartitionWriter}} clean, it is better
to get {{ResultPartitionID}} directly from
{{ResultPartitionDeploymentDescriptor}} instead of explicitly passing
additional {{ExecutionAttemptID}}.
We could create this {{ResultPartitionID}} in the constructor of
{{IntermediateResultPartition}}, then it can be got directly by other classes
to avoid repeatedly creation anywhere. Meanwhile this change would simply the
related codes.
> Refactor the creation of ResultPartitionID in IntermediateResultPartition
> -------------------------------------------------------------------------
>
> Key: FLINK-11750
> URL: https://issues.apache.org/jira/browse/FLINK-11750
> Project: Flink
> Issue Type: Sub-task
> Components: Network
> Reporter: zhijiang
> Assignee: zhijiang
> Priority: Minor
> Labels: pull-request-available
> Fix For: 1.9.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The motivation of task is for preparing the creation of {{ResultPartition}}
> via {{ShuffleService}} future.
> Currently during the creation of {{ResultPartition}} we need the
> {{ExecutionAttemptID}} info to generate {{ResultPartitionID}}. To make the
> interface of {{ShuffleService#createResultPartitionWriter}} clean, it is
> better to get {{ResultPartitionID}} directly from
> {{ResultPartitionDeploymentDescriptor}} instead of explicitly passing
> additional {{ExecutionAttemptID}}.
> We could create this {{ResultPartitionID}} during generating
> {{ResultPartitionDeploymentDescriptor}} to replace the original field of
> {{IntermediateResultPartitionID}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
