carp84 commented on a change in pull request #7841: [FLINK-11743] Fix RocksDB
incremental restore from local state after refactoring
URL: https://github.com/apache/flink/pull/7841#discussion_r260571497
##########
File path:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackendBuilder.java
##########
@@ -376,7 +376,7 @@ private static void checkAndCreateDirectory(File
directory) throws IOException {
ttlTimeProvider);
}
KeyedStateHandle firstStateHandle =
restoreStateHandles.iterator().next();
- boolean isIncrementalStateHandle = (firstStateHandle instanceof
IncrementalKeyedStateHandle)
+ boolean isIncrementalStateHandle = (firstStateHandle instanceof
IncrementalRemoteKeyedStateHandle)
|| (firstStateHandle instanceof
IncrementalLocalKeyedStateHandle);
Review comment:
Minor: `boolean isIncrementalStateHandle = firstStateHandle instanceof
IncrementalKeyedStateHandle` or we may even remove the variable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
