tzulitai commented on a change in pull request #7726: [FLINK-10342] Filter
restored partitions with discovered partitions b…
URL: https://github.com/apache/flink/pull/7726#discussion_r260583691
##########
File path:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java
##########
@@ -515,15 +510,17 @@ public void open(Configuration configuration) throws
Exception {
}
if (filterRestoredPartitionsWithDiscovered) {
-
subscribedPartitionsToStartOffsets.entrySet().removeIf(
- entry -> {
- if
(!allPartitions.contains(entry.getKey())) {
- LOG.warn("{} is removed
from subscribed Partitions.", entry.getKey());
- return true;
- }
- return false;
+ Iterator<Map.Entry<KafkaTopicPartition, Long>>
iter = subscribedPartitionsToStartOffsets.entrySet().iterator();
Review comment:
@fengli if by verify you also mean running tests, I usually just leave
Travis to do this.
Or, if the change is quite a localized change, I sometimes also just run the
relevant tests in the IDE.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
