fengli commented on a change in pull request #7726: [FLINK-10342] Filter
restored partitions with discovered partitions b…
URL: https://github.com/apache/flink/pull/7726#discussion_r260651429
##########
File path:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java
##########
@@ -515,15 +510,17 @@ public void open(Configuration configuration) throws
Exception {
}
if (filterRestoredPartitionsWithDiscovered) {
-
subscribedPartitionsToStartOffsets.entrySet().removeIf(
- entry -> {
- if
(!allPartitions.contains(entry.getKey())) {
- LOG.warn("{} is removed
from subscribed Partitions.", entry.getKey());
- return true;
- }
- return false;
+ Iterator<Map.Entry<KafkaTopicPartition, Long>>
iter = subscribedPartitionsToStartOffsets.entrySet().iterator();
Review comment:
Thanks guys. I installed checkstyle in intellij and use that for style
checking. The only drawback is the plugin doesn't have the same version as used
by mvn. But I guess that's just a minor issue, most of the time it'll just work.
For the travis test, is it possible to cancel or retrigger a test in case of
flink master build failure?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
