Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/750#discussion_r38186259
  
    --- Diff: 
flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java ---
    @@ -588,15 +653,16 @@ protected int cancel(String[] args) {
                        ActorGateway jobManager = getJobManagerGateway(options);
                        Future<Object> response = jobManager.ask(new 
CancelJob(jobId), askTimeout);
     
    -                   try {
    -                           Await.result(response, askTimeout);
    -                           return 0;
    -                   }
    -                   catch (Exception e) {
    -                           throw new Exception("Canceling the job with ID 
" + jobId + " failed.", e);
    +                   Object rc = Await.result(response, askTimeout);
    +
    +                   if (rc instanceof CancellationFailure) {
    --- End diff --
    
    Maybe we can do the same with the `CancellationFailure` as with the 
`StopFailure`, because I haven't found a place where we use the `jobID` field 
of the `CancellationFailure` instance.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to