bowenli86 commented on a change in pull request #7848: [FLINK-10755][table] 
Port external catalogs in Table API extension points to flink-table-common
URL: https://github.com/apache/flink/pull/7848#discussion_r260995325
 
 

 ##########
 File path: 
flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/ExternalCatalogTable.java
 ##########
 @@ -0,0 +1,390 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.catalog;
+
+import org.apache.flink.annotation.PublicEvolving;
+import org.apache.flink.table.descriptors.ConnectorDescriptor;
+import org.apache.flink.table.descriptors.Descriptor;
+import org.apache.flink.table.descriptors.DescriptorProperties;
+import org.apache.flink.table.descriptors.FormatDescriptor;
+import org.apache.flink.table.descriptors.Metadata;
+import org.apache.flink.table.descriptors.Schema;
+import org.apache.flink.table.descriptors.SchematicDescriptor;
+import org.apache.flink.table.descriptors.Statistics;
+import org.apache.flink.table.descriptors.StreamableDescriptor;
+import org.apache.flink.table.descriptors.TableDescriptor;
+import org.apache.flink.table.factories.TableFactory;
+import org.apache.flink.table.plan.stats.ColumnStats;
+import org.apache.flink.table.plan.stats.TableStats;
+
+import java.util.Map;
+import java.util.Optional;
+
+import static 
org.apache.flink.table.descriptors.StatisticsValidator.STATISTICS_COLUMNS;
+import static 
org.apache.flink.table.descriptors.StatisticsValidator.STATISTICS_ROW_COUNT;
+import static 
org.apache.flink.table.descriptors.StatisticsValidator.readColumnStats;
+import static 
org.apache.flink.table.descriptors.StreamTableDescriptorValidator.UPDATE_MODE;
+import static 
org.apache.flink.table.descriptors.StreamTableDescriptorValidator.UPDATE_MODE_VALUE_APPEND;
+import static 
org.apache.flink.table.descriptors.StreamTableDescriptorValidator.UPDATE_MODE_VALUE_RETRACT;
+import static 
org.apache.flink.table.descriptors.StreamTableDescriptorValidator.UPDATE_MODE_VALUE_UPSERT;
+
+/**
+ * Defines a table in an {@link ExternalCatalog}. External catalog tables 
describe table sources
+ * and/or sinks for both batch and stream environments.
+ *
+ * <p>See also {@link TableFactory} for more information about how to target 
suitable factories.
+ *
+ * <p>Use {@link ExternalCatalogTableBuilder} to integrate with the normalized 
descriptor-based API.
+ */
+@PublicEvolving
 
 Review comment:
   remove annotation

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to