TisonKun commented on a change in pull request #7780: [FLINK-11593][tests]
Check & port TaskManagerTest to new code base
URL: https://github.com/apache/flink/pull/7780#discussion_r261011365
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/TestingAbstractInvokables.java
##########
@@ -82,4 +84,94 @@ public void invoke() throws Exception {
}
}
}
+
+ /**
+ * Test invokable which blocks after invoke was called.
+ */
+ public static class BlockingInvokable extends AbstractInvokable {
Review comment:
We already have `org.apache.flink.runtime.testtasks.BlockingNoOpInvokable`
which is identical of this class. Could you just use it instead of introduce a
new identical class?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
