[ 
https://issues.apache.org/jira/browse/FLINK-11749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16780421#comment-16780421
 ] 

TisonKun commented on FLINK-11749:
----------------------------------

It comes from [this 
TODO|https://github.com/apache/flink/commit/064379705f36aaea927c44bb303a867c0c66265d#r32471762].

After a closer look I find I might get something wrong. What if a {{JobMaster}} 
has been suspended and re-started in ZOOKEEPER ha mode? It looks like we 
stopped {{resourceManagerLeaderRetriever}} and re-started it. But not only 
{{NodeCache}} can be started once, but {{ZooKeeperLeaderRetrievalService}} 
itself can be started once. Could you explain a bit what this TODO means?

> Returns the stored leadership info on ZooKeeperLeaderRetrievalService started
> -----------------------------------------------------------------------------
>
>                 Key: FLINK-11749
>                 URL: https://issues.apache.org/jira/browse/FLINK-11749
>             Project: Flink
>          Issue Type: Improvement
>          Components: Runtime / Coordination
>    Affects Versions: 1.9.0
>            Reporter: TisonKun
>            Assignee: TisonKun
>            Priority: Major
>             Fix For: 1.9.0
>
>
> Currently, such as in {{JobMaster}}, if we stop a 
> {{ZooKeeperLeaderRetrievalService}} and restart it, because the cached node 
> data isn't change, we have to manually flush it.
> I propose on {{ZooKeeperLeaderRetrievalService}} stated, get {{ChildData}} 
> from {{NodeCache}} and if the data isn't null, generate 
> LeadershipInfo(Address and UUID) and notify the listener.
> cc [~till.rohrmann]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to