sunhaibotb commented on issue #7797: [FLINK-11379] Fix OutOfMemoryError caused 
by Files.readAllBytes() when TM loads a large size TDD
URL: https://github.com/apache/flink/pull/7797#issuecomment-468273475
 
 
   > Not convinced that we're solving anything here. I could only find a single 
different line:
   > 
   > ```
   > Original:
   > while ((n = source.read(buf, nread, capacity - nread)) > 0)
   > ```
   > ```
   > Modified:
   > while ((n = source.read(buf, nread, Math.min(capacity - nread, 
BUFFER_SIZE))) > 0)
   > ```
   > This line however has no effect on the allocation of arrays.
   
   Please look at my previous reply: 
https://github.com/apache/flink/pull/7797#discussion_r261192511

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to