aljoscha commented on a change in pull request #7872: [FLINK-11420][core] Fixed
duplicate method of TraversableSerializer
URL: https://github.com/apache/flink/pull/7872#discussion_r261509197
##########
File path:
flink-core/src/test/java/org/apache/flink/api/common/typeutils/SerializerTestInstance.java
##########
@@ -62,19 +62,27 @@ protected int getLength() {
}
//
--------------------------------------------------------------------------------------------
-
+
public void testAll() {
- testInstantiate();
- testGetLength();
- testCopy();
- testCopyIntoNewElements();
- testCopyIntoReusedElements();
- testSerializeIndividually();
- testSerializeIndividuallyReusingValues();
- testSerializeAsSequenceNoReuse();
- testSerializeAsSequenceReusingValues();
- testSerializedCopyIndividually();
- testSerializedCopyAsSequence();
- testSerializabilityAndEquals();
+ try {
Review comment:
Do you know why these were not called before? Also, why do we need the
`try-catch` around this now?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services