[
https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14720362#comment-14720362
]
ASF GitHub Bot commented on FLINK-2111:
---------------------------------------
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/750#issuecomment-135852748
I just pushed an update addressing your comments. I additionally rework all
TaskManager and JobManager test.
Open issues:
1. how to deal with (potentially blocking) `userfunction.cancel()`
2. discussion about error message vs. exception (-> `StoppingFailiure`,
`CancelFailure`, and `TaskOperationResult`)
From my point of view, the error-message vs. exception thing could be
cleaned up in a different JIRA, in case it should be changed to use the
exception approach.
For `cancel` it might be sufficient to simply document that the call must
be non blocking.
> Add "stop" signal to cleanly shutdown streaming jobs
> ----------------------------------------------------
>
> Key: FLINK-2111
> URL: https://issues.apache.org/jira/browse/FLINK-2111
> Project: Flink
> Issue Type: Improvement
> Components: Distributed Runtime, JobManager, Local Runtime,
> Streaming, TaskManager, Webfrontend
> Reporter: Matthias J. Sax
> Assignee: Matthias J. Sax
> Priority: Minor
>
> Currently, streaming jobs can only be stopped using "cancel" command, what is
> a "hard" stop with no clean shutdown.
> The new introduced "stop" signal, will only affect streaming source tasks
> such that the sources can stop emitting data and shutdown cleanly, resulting
> in a clean shutdown of the whole streaming job.
> This feature is a pre-requirment for
> https://issues.apache.org/jira/browse/FLINK-1929
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
