pnowojski edited a comment on issue #7713: [FLINK-10995][network] Copy intermediate serialization results only once for broadcast mode URL: https://github.com/apache/flink/pull/7713#issuecomment-468709668 @zhijiangW in what scenarios is the `RecordWriter` being used for broadcasting messages? I'm asking since it might not be worth paying the price of more complex code to support this. Also I would be afraid that your proposed implementation of `RecordWriter` can behave worse in some scenarios with alternating broadcasted and not broadcasted messages compared to the previous version. In your proposal you are finishing buffers more often in that case, thus sending more empty buffers, causing more overhead for the network stack. One configuration where this could be especially visible is with for example SSL, where there is a significant cost of per message, regardless of the message size.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
