TisonKun commented on a change in pull request #7880: [FLINK-11336][zk] Delete
ZNodes when ZooKeeperHaServices#closeAndCleanupAllData
URL: https://github.com/apache/flink/pull/7880#discussion_r261670182
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/zookeeper/ZooKeeperHaServices.java
##########
@@ -225,6 +227,12 @@ public void closeAndCleanupAllData() throws Exception {
exception = t;
}
+ try {
+ cleanupZooKeeperPaths();
Review comment:
ZooKeeper has a method `ZKUtil#deleteRecursive` and Curator has a method
`ZKPaths#deleteChildren`. Either or them can do the same thing as
`#cleanupZooKeeperPaths`. We need not to re-implement it.
```java
ZKPaths.deleteChildren(client.getZookeeperClient().getZooKeeper(), "/",
true);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
