igalshilman commented on a change in pull request #7872: [FLINK-11420][core]
Fixed duplicate method of TraversableSerializer
URL: https://github.com/apache/flink/pull/7872#discussion_r261709583
##########
File path:
flink-core/src/test/java/org/apache/flink/api/common/typeutils/SerializerTestInstance.java
##########
@@ -60,29 +60,25 @@ protected int getLength() {
protected T[] getTestData() {
return this.testData;
}
-
+
//
--------------------------------------------------------------------------------------------
- public void testAll() {
- try {
- testConfigSnapshotInstantiation();
- testCopy();
- testCopyIntoNewElements();
- testCopyIntoReusedElements();
- testDuplicate();
- testGetLength();
- testInstantiate();
- testNullability();
- testSerializeIndividually();
- testSerializeIndividuallyReusingValues();
- testSerializeAsSequenceNoReuse();
- testSerializeAsSequenceReusingValues();
- testSerializedCopyIndividually();
- testSerializedCopyAsSequence();
- testSerializabilityAndEquals();
- testSnapshotConfigurationAndReconfigure();
- } catch (Exception ex) {
- throw new RuntimeException(ex);
- }
+ public void testAll() throws Exception {
Review comment:
I don't think this is needed, check my previous comment regarding sneakyThrow
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
