StefanRRichter commented on a change in pull request #7866: [FLINK-11730]
[State Backends] Make HeapKeyedStateBackend follow the builder pattern
URL: https://github.com/apache/flink/pull/7866#discussion_r261997545
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/state/StateBackend.java
##########
@@ -186,7 +187,8 @@
kvStateRegistry,
ttlTimeProvider,
new UnregisteredMetricsGroup(),
- Collections.emptyList());
+ Collections.emptyList(),
+ new CloseableRegistry());
Review comment:
This looks somehow wrong to do. I found that this method is (maybe
transitively) only really reached by tests. I suggest to remove the method and
call the full method to which it delegates in the tests instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
