StefanRRichter commented on a change in pull request #7899: [FLINK-11731]
[State Backends] Make DefaultOperatorStateBackend follow the builder pattern
URL: https://github.com/apache/flink/pull/7899#discussion_r262439351
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/state/DefaultOperatorStateBackend.java
##########
@@ -85,25 +73,15 @@
private final CloseableRegistry closeStreamOnCancelRegistry;
/**
- * Default serializer. Only used for the default operator state.
- */
- private final JavaSerializer<Serializable> javaSerializer;
-
- /**
- * The user code classloader.
+ * Default typeSerializer. Only used for the default operator state.
*/
- private final ClassLoader userClassloader;
+ private final TypeSerializer<Serializable> typeSerializer;
Review comment:
I suggest to change the name of this field. `typeSerializer` is general and
makes it look like this is a very commonly used field. However, this is more
like a very static field, that always gets assigned the same type of serializer
and is only used in deprecated context (see one of my other comments in the
builder about this). I suggest something like `deprecatedDefaultJavaSerializer`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
