azagrebin commented on a change in pull request #7889: [FLINK-11665] Wait for
job termination before recovery in Dispatcher
URL: https://github.com/apache/flink/pull/7889#discussion_r262562979
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java
##########
@@ -313,8 +318,6 @@ private void stopDispatcherServices() throws Exception {
final CompletableFuture<JobManagerRunner>
jobManagerRunnerFuture = createJobManagerRunner(jobGraph);
- jobManagerRunnerFutures.put(jobGraph.getJobID(),
jobManagerRunnerFuture);
Review comment:
My PR probably changed timing for events happening in some unit tests and
triggered a concurrency issue fixed by this change. The PR would have test
instability without this change. I think it is small enough to be part of this
PR, though, I can factor it out into a separate commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
