JingsongLi commented on a change in pull request #7944:
[FLINK-11863][table-runtime-blink] Introduce channel to read and write
compressed data
URL: https://github.com/apache/flink/pull/7944#discussion_r263981141
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/memory/AbstractPagedInputView.java
##########
@@ -160,6 +160,11 @@ protected final void advance() throws IOException {
this.positionInSegment = this.headerLength;
}
+ /**
+ * This method will run after advance(). Override it if you want to use
it.
+ */
+ protected void afterAdvance() {}
Review comment:
Is afterAdvance() just to support setting initial offset of InputView? It's
a little too heavy to add an method afterAdvance(). Consider override advance()
in the HeaderlessChannelReaderInputView and set positionInSegment the first
time?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
