link3280 commented on a change in pull request #7895:
[FLINK-11126][YARN][security] Filter out AMRMToken in TaskManager‘s credentials
URL: https://github.com/apache/flink/pull/7895#discussion_r263984640
##########
File path: flink-yarn/src/test/java/org/apache/flink/yarn/UtilsTest.java
##########
@@ -58,4 +87,84 @@ public void testDeleteApplicationFiles() throws Exception {
assertThat(files.count(), equalTo(0L));
}
}
+
+ @Test
+ public void testCreateTaskExecutorContext() throws Exception {
Review comment:
Yeah, I think it's sort of complicated as a unit test and does not have good
separation of concerns. Actually, the test is extended from a test in legacy
mode that only verifies the local resources of TaskManagers. It's a good idea
to refactor it in a util method and make it available in `flink-yarn-tests`,
but I still want to to have a test for `Utils.createTaskExecutorContext`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
