hequn8128 commented on issue #6787: [FLINK-8577][table] Implement proctime 
DataStream to Table upsert conversion
URL: https://github.com/apache/flink/pull/6787#issuecomment-471279445
 
 
   @pnowojski I have reimplemented the PR and reused the Aggregate node. 
However, when I try to add the transpose logic I find we need a more generic 
rule to transpose Calc and Aggregate. Maybe we can add a rule in Calcite, so 
could I remove the transpose logic from the current PR and implement it later? 
This can also help us to make the current PR smaller thus easier to be reviewed 
and merged. 
   What do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to