twalthr commented on a change in pull request #7920: [FLINK-11844][table-api]
Simplify over window API classes and improve documentation
URL: https://github.com/apache/flink/pull/7920#discussion_r264116254
##########
File path:
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/api/windows.scala
##########
@@ -20,90 +20,180 @@ package org.apache.flink.table.api
import org.apache.flink.table.expressions._
import org.apache.flink.table.plan.logical._
-import org.apache.flink.table.typeutils.{RowIntervalTypeInfo,
TimeIntervalTypeInfo}
-import org.apache.flink.table.api.scala.{CURRENT_RANGE, CURRENT_ROW}
/**
- * Over window is similar to the traditional OVER SQL.
+ * A over-window specification.
Review comment:
Thanks for the hint. Yes, we should be consistent. Actually, this was the
only remaining of `over-window`. I changed it to `over window`. Now we should
be consistent with `tumbling windows, session windows` etc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
