klion26 commented on a change in pull request #7958:
[FLINK-11881][table-planner-blink] Introduce code generated typed sort to blink
table
URL: https://github.com/apache/flink/pull/7958#discussion_r264520796
##########
File path:
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/generated/CompileUtils.java
##########
@@ -87,4 +88,13 @@
throw new RuntimeException("Can not load class " +
name, e);
}
}
+
+ private static String addLineNumber(String code) {
+ String[] lines = code.split("\n");
+ StringBuilder builder = new StringBuilder();
+ for (int i = 0; i < lines.length; i++) {
Review comment:
do we need to start from 1 instead of 0?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
