KurtYoung commented on a change in pull request #7958:
[FLINK-11881][table-planner-blink] Introduce code generated typed sort to blink
table
URL: https://github.com/apache/flink/pull/7958#discussion_r264970786
##########
File path:
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/sort/NormalizedKeyComputer.java
##########
@@ -29,14 +27,6 @@
*/
public abstract class NormalizedKeyComputer {
Review comment:
maybe we should move these interfaces which will mainly used with code
generator together? like to package `org.apache.flink.table.generated` ? I
created `Projection` and `JoinCondition` in previous PR and place them there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
