Myasuka opened a new pull request #7970: [FLINK-11874][checkpoint] Split CheckpointStorage interface to distinguish JM and TM side URL: https://github.com/apache/flink/pull/7970 ## What is the purpose of the change Currently, interface `CheckpointStorage` mixed JM and TM side, which would be confusing for users and developers to distinguish them. This pull request split original `CheckpointStorage` to a only JM side `CheckpointCoordinatorStorage` and new only TM side `CheckpointStorage`. ## Brief change log - Keep only two methods which used in task side in `CheckpointStorgae`: ~~~ java CheckpointStreamFactory resolveCheckpointStorageLocation( long checkpointId, CheckpointStorageLocationReference reference) CheckpointStateOutputStream createTaskOwnedStateStream() ~~~ - Move four methods which used in JM side to new `CheckpointCoordinatorStorage`: ~~~ java boolean supportsHighlyAvailableStorage() boolean hasDefaultSavepointLocation() CompletedCheckpointStorageLocation resolveCheckpoint(String externalPointer) CheckpointStorageLocation initializeLocationForCheckpoint(long checkpointId) CheckpointStorageLocation initializeLocationForSavepoint( long checkpointId, @Nullable String externalLocationPointer) ~~~ - Refactor tests to let those which only verify task side not mix up the role of checkpoint storage really acts. ## Verifying this change This change is a interface refactor, current tests could cover it. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): **no** - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **yes** - The serializers: **no** - The runtime per-record code paths (performance sensitive): **no** - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: **no** - The S3 file system connector: **no** ## Documentation - Does this pull request introduce a new feature? **no** - If yes, how is the feature documented? **not applicable**
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
