StefanRRichter commented on a change in pull request #7959: [FLINK-11876] Introduce new TwoInputSelectable, BoundedOneInput and BoundedTwoInput interfaces URL: https://github.com/apache/flink/pull/7959#discussion_r265096474
########## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/BoundedTwoInput.java ########## @@ -0,0 +1,33 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.streaming.api.operators; + +import org.apache.flink.annotation.PublicEvolving; + +/** + * Interface for the two-input operator that can process EndOfInput event. + */ +@PublicEvolving +public interface BoundedTwoInput { + + /** + * It is notified that no more data will arrive on the input identified + * by {@code inputId}. + */ + void endInput(InputIdentifier inputId) throws Exception; Review comment: Is there any reason why we want to special-case between one-input and two-input, when this interface can actually work for [1..n(32?)]-inputs? Why not unify into just this one interface? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
