sunjincheng121 commented on issue #7664: [FLINK-11449][table] Uncouple the Expression class from RexNodes. URL: https://github.com/apache/flink/pull/7664#issuecomment-472744666 Um, OrcTableSource#applyPredicate will call `toOrcPredicate` method which using the plannerExpreasion, such as `Or`, So, the connector should dependent on `flink-table-planner` module, which we do not want. So IMHO. if we want to reduce connector user's dependences, we need this change at the current time. Just like we do not want API user to depend on `flink-table-planner` when they write job logic. is there anything I missed?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
