wuchong commented on a change in pull request #7969: [FLINK-11896]
[table-planner-blink] Introduce stream physical nodes
URL: https://github.com/apache/flink/pull/7969#discussion_r265498282
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/plan/nodes/physical/stream/StreamPhysicalRel.scala
##########
@@ -48,4 +48,8 @@ trait StreamPhysicalRel extends FlinkPhysicalRel {
*/
def producesRetractions: Boolean = false
+ /**
+ * Whether the [[StreamPhysicalRel]] requires rowtime watermark in
processing logic.
+ */
+ def requireWatermark: Boolean = false
Review comment:
How about to remove all default value for the interface methods to force the
concrete node to implement them?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
