pnowojski commented on a change in pull request #7713: [FLINK-10995][network]
Copy intermediate serialization results only once for broadcast mode
URL: https://github.com/apache/flink/pull/7713#discussion_r265546476
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/api/writer/RecordWriterTest.java
##########
@@ -311,7 +334,7 @@ public void testBroadcastEventBufferReferenceCounting()
throws Exception {
ResultPartitionWriter partition =
new CollectingPartitionWriter(queues, new
TestPooledBufferProvider(Integer.MAX_VALUE));
- RecordWriter<?> writer =
RecordWriterBuilder.createRecordWriter(partition);
+ RecordWriter<?> writer = createRecordWriter(partition);
Review comment:
If this is a test fix, not a refactor, this change should be in separate
commit. However I think this is going to be changed anyway, because of my
pending "Builder pattern" comment/issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
