HuangZhenQiu commented on a change in pull request #7978: [FLINK-11910] [Yarn] 
add customizable yarn application type
URL: https://github.com/apache/flink/pull/7978#discussion_r265620892
 
 

 ##########
 File path: 
flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
 ##########
 @@ -468,6 +470,8 @@ private void 
validateClusterSpecification(ClusterSpecification clusterSpecificat
                        flinkConfiguration.setString(dynProperty.getKey(), 
dynProperty.getValue());
                }
 
+               this.flinkVersion = dynProperties.getOrDefault("flink-version", 
"");
 
 Review comment:
   For most of the cases, we can get the precise version of flinkJarPath. But 
for some deployment systems that submit jobs from customers, different jar will 
be used. Probably, using dynamic properties can give more flexibility here. How 
do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to