dianfu commented on issue #7848: [FLINK-10755][table] Port external catalogs in Table API extension points to flink-table-common URL: https://github.com/apache/flink/pull/7848#issuecomment-473886791 @twalthr Thanks a lot for the review. Considering that this change will break the API of FieldComputer and the serialization of Rowtime, I'd like to take the original solution and avoid the changes of ExternalCatalogBuilder. What do you think? I intended to avoid removing the method ExternalCatalogTable.builder() before (as done in the current PR), but it seems that removing it would be a nicer solution.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
