aljoscha commented on a change in pull request #7921:
[FLINK-11825][StateBackends] Resolve name clash of StateTTL TimeCharacteristic
class
URL: https://github.com/apache/flink/pull/7921#discussion_r266823368
##########
File path:
flink-core/src/main/java/org/apache/flink/api/common/state/StateTtlConfig.java
##########
@@ -204,16 +218,31 @@ public Builder neverReturnExpired() {
* Sets the time characteristic.
*
* @param timeCharacteristic The time characteristic configures
time scale to use for ttl.
+ *
+ * @deprecated will be removed in a future version in favor of
{@link #setTtlTimeCharacteristic}
*/
+ @Deprecated
@Nonnull
public Builder setTimeCharacteristic(@Nonnull
TimeCharacteristic timeCharacteristic) {
- this.timeCharacteristic = timeCharacteristic;
+ // We only support ProcessingTime now, so transfer to
{@link TtlTimeCharacteristic.ProcessingTime} directly.
Review comment:
What's happening here? We're silently ignoring the parameter that was passed
in?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
