JingsongLi commented on a change in pull request #8001: [FLINK-11949][table-planner-blink] Introduce DeclarativeAggregateFunction and AggsHandlerCodeGenerator to blink planner URL: https://github.com/apache/flink/pull/8001#discussion_r266840077
########## File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/generated/AggsHandleFunction.java ########## @@ -0,0 +1,97 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.generated; + +import org.apache.flink.api.common.functions.Function; +import org.apache.flink.table.dataformat.BaseRow; +import org.apache.flink.table.runtime.functions.ExecutionContext; + +/** + * The base class for handling aggregate functions. + */ +public interface AggsHandleFunction extends Function { + + /** + * Initialization method for the function. It is called before the actual working methods. + */ + void open(ExecutionContext ctx) throws Exception; + + /** + * Accumulates the input values to the accumulators. + * @param input input values bundled in a row + */ + void accumulate(BaseRow input) throws Exception; + + /** + * Retracts the input values from the accumulators. + * @param input input values bundled in a row + */ + void retract(BaseRow input) throws Exception; + + /** + * Merges the other accumulators into current accumulators. + * + * @param accumulators The other row of accumulators + */ + void merge(BaseRow accumulators) throws Exception; + + /** + * Set the current accumulators (saved in a row) which contains the current. + * aggregated results + * @param accumulators current accumulators + */ + void setAccumulators(BaseRow accumulators) throws Exception; Review comment: Yes, not only streaming state, but also batch hash aggregation buffer(Need support in the future). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
