azagrebin commented on a change in pull request #7549: [FLINK-11403][network]
Remove ResultPartitionConsumableNotifier from ResultPartition
URL: https://github.com/apache/flink/pull/7549#discussion_r266829976
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/writer/ResultPartitionWriter.java
##########
@@ -49,7 +49,7 @@
* <p>To avoid problems with data re-ordering, before adding new {@link
BufferConsumer} the previously added one
* the given {@code subpartitionIndex} must be marked as {@link
BufferConsumer#isFinished()}.
*/
- void addBufferConsumer(BufferConsumer bufferConsumer, int
subpartitionIndex) throws IOException;
+ boolean addBufferConsumer(BufferConsumer bufferConsumer, int
subpartitionIndex) throws IOException;
Review comment:
minor thing: let's maybe add `@returns` in docs for `returns whether
successful or not`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
