[ 
https://issues.apache.org/jira/browse/FLINK-2480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14725308#comment-14725308
 ] 

ASF GitHub Bot commented on FLINK-2480:
---------------------------------------

Github user HuangWHWHW commented on the pull request:

    https://github.com/apache/flink/pull/1073#issuecomment-136694516
  
    @StephanEwen 
    Hi, I take changes for all of your comments but this following:
    
    "The mock print stream overwrites only one println() function, which makes 
it susceptible to changes in the sink. It is better to use a regular 
PrintStream that prints to a StringWriter to collect all contents."
    
    I have no ideas to assert the print is correct.
    So can you tell me in detail?
    Thank you very much!


> Improving tests coverage for org.apache.flink.streaming.api
> -----------------------------------------------------------
>
>                 Key: FLINK-2480
>                 URL: https://issues.apache.org/jira/browse/FLINK-2480
>             Project: Flink
>          Issue Type: Test
>          Components: Streaming
>    Affects Versions: 0.10
>            Reporter: Huang Wei
>             Fix For: 0.10
>
>   Original Estimate: 504h
>  Remaining Estimate: 504h
>
> The streaming API is quite a bit newer than the other code so it is not that 
> well covered with tests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to