zhijiangW commented on a change in pull request #7549: [FLINK-11403][network]
Remove ResultPartitionConsumableNotifier from ResultPartition
URL: https://github.com/apache/flink/pull/7549#discussion_r267178927
##########
File path:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/io/benchmark/StreamNetworkBenchmarkEnvironment.java
##########
@@ -236,21 +237,23 @@ protected ResultPartitionWriter createResultPartition(
NetworkEnvironment environment,
int channels) throws Exception {
- ResultPartition resultPartition = new ResultPartition(
+ NetworkResultPartition networkResultPartition = new
NetworkResultPartition(
"sender task",
- new NoOpTaskActions(),
- jobId,
partitionId,
ResultPartitionType.PIPELINED_BOUNDED,
channels,
1,
environment.getResultPartitionManager(),
+ ioManager);
+ environment.setupPartition(networkResultPartition);
+
+ ResultPartition resultPartition = new ResultPartition(
Review comment:
From functional aspect, I agree with your point. But it seems reasonable to
reflect the real path for performance sensitive benchmark. If there are extra
overheads executed in `ResultPartition`, it could be detected in the benchmark.
What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
