KurtYoung commented on a change in pull request #8017: [hotfix][table]
Introduced UnresolvedFieldReference & ResolvedFieldReference expressions
URL: https://github.com/apache/flink/pull/8017#discussion_r267306321
##########
File path:
flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/expressions/RexNodeConverter.java
##########
@@ -206,7 +206,9 @@ public RexNode visitTypeLiteral(TypeLiteralExpression
typeLiteral) {
@Override
public RexNode visit(Expression other) {
- if (other instanceof ResolvedAggInputReference) {
+ if (other instanceof UnresolvedFieldReferenceExpression) {
Review comment:
I need some clarification here. AFAIK, the only "unresolved" expressions
only exist during the phase we constructing table API in original Flink, right?
The unresolved expression never get a chance to translate to Calcite's RexNode.
It should be resolved before that or an exception will throw.
Are we changing this now? If we want to change this, it will be a little
ambiguous with who are responsible for resolving all these expressions. Not
sure "ExpressionVisitor" is the one, since it can see unresolved & resolved
expressions in the same time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
