dawidwys commented on a change in pull request #8017: [hotfix][table]
Introduced UnresolvedFieldReference & ResolvedFieldReference expressions
URL: https://github.com/apache/flink/pull/8017#discussion_r267311782
##########
File path:
flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/expressions/RexNodeConverter.java
##########
@@ -206,7 +206,9 @@ public RexNode visitTypeLiteral(TypeLiteralExpression
typeLiteral) {
@Override
public RexNode visit(Expression other) {
- if (other instanceof ResolvedAggInputReference) {
+ if (other instanceof UnresolvedFieldReferenceExpression) {
Review comment:
Yes I agree `UnresolvedFieldReference` cannot be translated into RexNode and
also that it should never end up in the Planner. This is also the main purpose
of the `UnresolvedFieldReference` to make this distinction clear.
`ExpressionVisitor` is just a way to traverse the operation tree. I am
currently working on moving all the resolution of expressions into a single
place in the API module, as part of FLINK-11884. I agree we should move this
resolution here up to the API module as well once it's in place.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
