azagrebin commented on a change in pull request #7822: [FLINK-11726][network]
Refactor the creation of ResultPartition and InputGate into NetworkEnvironment
URL: https://github.com/apache/flink/pull/7822#discussion_r267852416
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java
##########
@@ -299,7 +296,7 @@ public Task(
@Nonnull TaskMetricGroup metricGroup,
ResultPartitionConsumableNotifier
resultPartitionConsumableNotifier,
PartitionProducerStateChecker partitionProducerStateChecker,
- Executor executor) {
+ Executor executor) throws IOException {
Review comment:
It seems that partition/gate setup causes the exception. Usually,
constructors should be able always just construct objects without doing any IO
and throwing exceptions. If partition/gate had a lifecycle `setup()` interface
method, which would do the same as `NetworkEnviroment.setupPartition/Gate`,
then the setup could stay in the same place in `Task.run` as originally, do IO
and throw exceptions while running.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
