SuXingLee commented on a change in pull request #7966: [FLINK-11887][metrics]
Fixed latency metrics drift apart
URL: https://github.com/apache/flink/pull/7966#discussion_r267976961
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/StreamSource.java
##########
@@ -154,7 +154,7 @@ public LatencyMarksEmitter(
public void onProcessingTime(long
timestamp) throws Exception {
try {
//
ProcessingTimeService callbacks are executed under the checkpointing lock
-
output.emitLatencyMarker(new LatencyMarker(timestamp, operatorId,
subtaskIndex));
+
output.emitLatencyMarker(new LatencyMarker(System.currentTimeMillis(),
operatorId, subtaskIndex));
Review comment:
I read the test case carefully, and found that this test case is use to
verify ```SystemProcessingTimeService``` , but we don't accumulate a fixed time
interval periodicity to producer millisecond time. so the test logic is not
useful, i remove this test again,if keep it,will cause BUILD FAILURE.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
