pnowojski commented on a change in pull request #7911: [FLINK-11082][network]
Fix the logic of getting backlog in sub partition
URL: https://github.com/apache/flink/pull/7911#discussion_r268145093
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultSubpartition.java
##########
@@ -115,52 +115,62 @@ protected Throwable getFailureCause() {
public abstract boolean isReleased();
+ public abstract boolean isFinished();
Review comment:
Does it have to be public? If yes, then I think it should be named
`isFinishedUnsafe()`. More or less we are creating a convention here as we go,
but I think for private/protected methods we can ignore unsafe suffixes as long
as there exists only one version of such method. Here existence of thread-safe
`isReleased()` adds to the confusion and suggests that `isFinished()` should be
thread-safe as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
