aljoscha commented on a change in pull request #7605: [FLINK-11463][PROTOTYPE] 
Port Kafka E2E test to Java
URL: https://github.com/apache/flink/pull/7605#discussion_r268147030
 
 

 ##########
 File path: 
flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/FlinkDistribution.java
 ##########
 @@ -68,6 +71,8 @@
 
        private final List<AutoClosablePath> filesToDelete = new ArrayList<>(4);
 
+       private final Optional<Path> backupDir;
 
 Review comment:
   At first I was confused why we need backups of the distribution. Maybe this 
could be called `logUploadDir`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to